Format incomplete records without type tags when requested. #200
+20
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside of other types, they could be formatted as e.g. `struct Foo;`, when a complete struct would be just `Foo`. This is because of a really fiddly diverging code path that basically just seems to be a bad factorization. In practice this seems to result in no changes to the output, and is a pure simplification. PiperOrigin-RevId: 846446543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format incomplete records without type tags when requested.
Inside of other types, they could be formatted as e.g.
struct Foo;, when a complete struct would be justFoo. This is because of a really fiddly diverging code path that basically just seems to be a bad factorization. In practice this seems to result in no changes to the output, and is a pure simplification.