Use fully qualified names for error messages. #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d84ebd to
a27fff2
Compare
This, in turn, gives us a useful and distinct key to aggregate on with error reporting infra. Also, it disambiguates errors in the event that there's many things with the same name. ;) --- The reason this works is that record IDs are always recorded as the enclosing item ID. Indeed, the record_id field is completely redundant -- this CL shows that much, and I will delete it in a followup CL. PiperOrigin-RevId: 849309009
a27fff2 to
6b212f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fully qualified names for error messages.
This, in turn, gives us a useful and distinct key to aggregate on with error reporting infra.
Also, it disambiguates errors in the event that there's many things with the same name. ;)
The reason this works is that record IDs are always recorded as the enclosing item ID. Indeed, the record_id field is completely redundant -- this CL shows that much, and I will delete it in a followup CL.