Delete redundant record ID in the IR. #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function _never_ has a record ID different from its enclosing record. And it isn't even useful in a typed way, because the record_id might not be a Item::Record! May as well always use the enclosing_record_id (and check for Namespace if you really need to). The previous CLs in the chain relied on the fact that this was redundant. Deleting it properly helps for the proof. PiperOrigin-RevId: 846446546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete redundant record ID in the IR.
A function never has a record ID different from its enclosing record. And it isn't even useful in a typed way, because the record_id might not be a Item::Record! May as well always use the enclosing_record_id (and check for Namespace if you really need to).
The previous CLs in the chain relied on the fact that this was redundant. Deleting it properly helps for the proof.