- 
                Notifications
    
You must be signed in to change notification settings  - Fork 954
 
[BSv5] Adapt cardpane shortcode #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an entry to the CHANGELOG, under breaking-changes so that users are aware of the class name change?
| 
           This PR improves the rendering of card panes, but note that this change still doesn't bring the concerned page in visual agreement with what the paged looked like before. Before (https://deploy-preview-1356--docsydocs.netlify.app/docs/adding-content/shortcodes/#card-panes): With this PR (https://deploy-preview-1376--docsydocs.netlify.app/docs/adding-content/shortcodes/#card-panes):  | 
    
          
 Done.  | 
    
          
 I was aware of this when submitting the PR. From the bootstrap migration guide Using of the bootstrap grid in the   | 
    
a6473d2    to
    cfcbfe1      
    Compare
  
    
          
 On a second attempt, I now was able to bring the concerned page in visual agreement with what the page looked before.  | 
    
0b6d928    to
    3e7ba96      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
Also pls rebase, then I'll do a final review.
          
 Done. 
 Thanks.  | 
    
| 
           Following up on #906, I reworked the  
  | 
    
8c4f607    to
    523b941      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is layouts/shortcodes/card-code.html actually still used? It seems to me that this PR was getting rid of it, but the file is still present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the question about card-code and border, LGTM. Thanks!
          
 No, in the userguide, we don't use it any more. 
 CHANGELOG: I wrote  
 Yes, this is intentional: if I remove the shortcode, this will break all existing pages that make use of this shortcode and we will force users to adapt their pages (by replacing shortcode  Does that clarify things? Would you like to see the file deleted?  | 
    
          
 I rebased the PR to get it ready for merging. Let me know if you want me to delete the   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your clarifications. See inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased and resolved the minor conflicts. Thanks for the progressive improvements to this PR.
LGTM ✨
per [BSv5] Adapt cardpane shortcode #1376 (comment)
Preview: https://deploy-preview-1376--docsydocs.netlify.app/docs/adding-content/shortcodes/#card-panes