shortcode 'blocks/lead' improvements #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb9773 to
f4e41f6
Compare
8 tasks
- use Hugo's native support for processing HTML & markdown (google#906) - drop support for pre-Hugo-0.54.x behavior of {{% %}} google#939
Otherwise, when processed as Markdown, it gets auto-wrapped in a paragraph.
|
I've rebased, resolved conflicts and made a fix & a few adjustments. Will carefully re-read after my next meeting then merge as I want to submit a BSv5 fix on top of this. Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #906. It contains improvements for the shortcode
blocks/lead:endcondition of the html block containing the shortcode body (as defined in the CommonMark spec, number 7).heightcontains an invalid value{{% %}}#939)The PR also adds a paragraph to the user guide explaining the proper use of the shortcode with different markups (markdown/html).