Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

fix: Do not fail if physical location of VM is not available #153

Merged
aojea merged 1 commit into from
Jul 8, 2025
Merged

fix: Do not fail if physical location of VM is not available #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/cloudprovider/gce/gce.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,16 @@ func GetInstance(ctx context.Context) (*cloudprovider.CloudInstance, error) {
klog.Infof("could not get network interfaces on GCE ... retrying: %v", err)
return false, nil
}
// Physical location of VM is not always available. We don't fail if
// it's not available.
//
// Ref. https://cloud.google.com/compute/docs/instances/use-compact-placement-policies#verify-vm-location
gceTopologyAttributes, err := metadata.GetWithContext(ctx, "instance/attributes/physical_host")
if err != nil {
klog.Infof("could not get physical host on GCE ... retrying: %v", err)
return false, nil
klog.Warningf("Failed to retrieve physical host for GCE VM %q, this maybe normal since not all VMs and VM types have this populated: %v", instanceName, err)
} else {
instance.Topology = gceTopologyAttributes
}
instance.Topology = gceTopologyAttributes
return true, nil
})
if err != nil {
Expand Down
Loading