-
Notifications
You must be signed in to change notification settings - Fork 24
Trap SIGTERM for handling graceful shutdown with related cleanup and e2e test. #163
Trap SIGTERM for handling graceful shutdown with related cleanup and e2e test. #163
Conversation
|
The test added is failing "not ok 13 driver should gracefully shutdown when terminated # timeout after 120s" |
Yeah I'm seeing some interesting behaviour due to the bpf mounts:
The test passes when run individually. Will take a look (maybe tomorrow) |
a1091cf to
95f4b0d
Compare
I'm thinking of disabling the 3 bpf tests for now and we can investigate it separately in #164. As we see, the tests do pass without the bpf tests. |
95f4b0d to
b7c021c
Compare
|
LGTM @michaelasp @gauravkghildiyal merge once you are fine |
michaelasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well!
|
Thank you both for the review! |
Before: We only listened for SIGINT, while kubernetes uses SIGTERM.
Closes #164