Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@gauravkghildiyal
Copy link
Member

@gauravkghildiyal gauravkghildiyal commented Jul 15, 2025

Before: We only listened for SIGINT, while kubernetes uses SIGTERM.

Closes #164

@aojea
Copy link
Collaborator

aojea commented Jul 15, 2025

The test added is failing "not ok 13 driver should gracefully shutdown when terminated # timeout after 120s"

@gauravkghildiyal
Copy link
Member Author

The test added is failing "not ok 13 driver should gracefully shutdown when terminated # timeout after 120s"

Yeah I'm seeing some interesting behaviour due to the bpf mounts:

Warning Failed 4m13s (x62 over 17m) kubelet (combined from similar events): Error: failed to generate container "dd27c26e7ba91d111760a9070b946fb1aa768181fb76be0d41430d30326bc3f3" spec: failed to apply OCI options: path "/sys/fs/bpf" is mounted on "/sys/fs/bpf" but it is not a shared or slave mount

The test passes when run individually. Will take a look (maybe tomorrow)

@gauravkghildiyal
Copy link
Member Author

The test added is failing "not ok 13 driver should gracefully shutdown when terminated # timeout after 120s"

Yeah I'm seeing some interesting behaviour due to the bpf mounts:

Warning Failed 4m13s (x62 over 17m) kubelet (combined from similar events): Error: failed to generate container "dd27c26e7ba91d111760a9070b946fb1aa768181fb76be0d41430d30326bc3f3" spec: failed to apply OCI options: path "/sys/fs/bpf" is mounted on "/sys/fs/bpf" but it is not a shared or slave mount

The test passes when run individually. Will take a look (maybe tomorrow)

I'm thinking of disabling the 3 bpf tests for now and we can investigate it separately in #164. As we see, the tests do pass without the bpf tests.

@aojea
Copy link
Collaborator

aojea commented Jul 15, 2025

LGTM @michaelasp @gauravkghildiyal merge once you are fine

Copy link
Collaborator

@michaelasp michaelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@gauravkghildiyal
Copy link
Member Author

Thank you both for the review!

@gauravkghildiyal gauravkghildiyal merged commit 27aed0a into google:main Jul 15, 2025
6 checks passed
@gauravkghildiyal gauravkghildiyal linked an issue Jul 16, 2025 that may be closed by this pull request
@gauravkghildiyal gauravkghildiyal deleted the graceful-shutdown branch July 18, 2025 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and re-enable e2e test failures BPF related tests [Investigate] Graceful shutdown testing

3 participants