This repository was archived by the owner on Dec 9, 2025. It is now read-only.
fix: Use complete PCI Address in BDF format when using GetPCIeRootAttributeByPCIBusID #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5da793 to
07c5dac
Compare
aojea
reviewed
Aug 21, 2025
07c5dac to
f6dadac
Compare
Collaborator
|
Man PCI can get confusing 😅, who'd have thought we wouldn't want the bus when it specifies the bus. Thanks for catching this! |
michaelasp
approved these changes
Aug 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function name is confusing and makes one think it only wants the "Bus", but actually it expects the complete BDF notation (which as I also just learned, is also sometimes called a bus)
Without this, the function will fail at https://github.com/kubernetes/dynamic-resource-allocation/blob/f977084efa0c474b35eb9ad3131cf04f1313a917/deviceattribute/pci_linux.go#L43