This repository was archived by the owner on Dec 9, 2025. It is now read-only.
test: Revert back to sleeping for 5 seconds between tests #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman0408
approved these changes
Aug 28, 2025
211d323 to
c973f36
Compare
aojea
approved these changes
Aug 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver is rate limited to updates with interval of atleast 5 seconds:
dranet/pkg/inventory/db.go
Line 46 in 5f2c377
dranet/pkg/inventory/db.go
Line 128 in 5f2c377
So we need to sleep for an equivalent amount of time to ensure state from a previous test is cleared up and old (non-existent) devices have been removed from the ResourceSlice. This seems to only be an an issue of the test where we create "dummy" interfaces which disappear if the network namespace is deleted.
We were previously sleeping for 5 seconds but that was changed in #208 to 2 seconds which is causing flakes like https://github.com/google/dranet/actions/runs/17281340446/job/49050151995