This repository was archived by the owner on Dec 9, 2025. It is now read-only.
add prometheus metrics for DRA and NRI functions #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aojea
reviewed
Aug 29, 2025
aojea
reviewed
Aug 29, 2025
aojea
reviewed
Aug 29, 2025
aojea
reviewed
Aug 29, 2025
Member
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Still pending review of other stuff, but the general direction I'd recommend us to go here is that we have public wrapper function which handles tasks like metrics and error logging, while an internal function focuses solely on the core business logic. This separation ensures metrics are captured consistently and makes the code more readable and maintainable over time. For example, PrepareResourceClaims() could call an internal prepareResourceClaims().
5907f25 to
cbf850e
Compare
aojea
reviewed
Sep 3, 2025
aojea
reviewed
Sep 3, 2025
michaelasp
reviewed
Sep 3, 2025
Member
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Just a minor suggestion, looking good. Thanks @aman0408
cbf850e to
4e2b864
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics for DRA and NRI functions - latency and success/failure as discussed in #90