-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Add noop status to metrics in NRI hooks #245
Conversation
cbd4f76 to
ec8984e
Compare
|
at first sight I do not like much keep plumbing things down, can we ignore the metric without having to keep passing parameters just for that? |
@aojea this metric label is required to ignore metrics generated from other pods. I have modified the approach and now returning an extra variable instead of passing it down. Could you please take a look and suggest an approach on how we can improve this? |
ec8984e to
3011319
Compare
3011319 to
f8366d3
Compare
|
@michaelasp, @aojea I hope the changes and the rationale make sense now. I'll proceed with merging assuming you were fine with the current state. If there's additional changes, we can follow up separately. |
it is ok, the logic is not encapsulated into the methods, and we are not spreading the metrics details |
Added
noopstatus value tonriPluginRequestsTotalandnriPluginRequestsLatencySecondsto be able to filter out metrics that are relevant to the driver and ignore others.