Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@aman0408
Copy link
Collaborator

@aman0408 aman0408 commented Sep 26, 2025

Added noop status value to nriPluginRequestsTotal and nriPluginRequestsLatencySeconds to be able to filter out metrics that are relevant to the driver and ignore others.

@aman0408 aman0408 marked this pull request as ready for review September 26, 2025 21:50
@aman0408 aman0408 force-pushed the add-managed-pod-label branch 3 times, most recently from cbd4f76 to ec8984e Compare September 27, 2025 09:28
@aojea
Copy link
Collaborator

aojea commented Sep 27, 2025

at first sight I do not like much keep plumbing things down, can we ignore the metric without having to keep passing parameters just for that?

@aman0408
Copy link
Collaborator Author

at first sight I do not like much keep plumbing things down, can we ignore the metric without having to keep passing parameters just for that?

@aojea this metric label is required to ignore metrics generated from other pods. I have modified the approach and now returning an extra variable instead of passing it down. Could you please take a look and suggest an approach on how we can improve this?

@aman0408 aman0408 force-pushed the add-managed-pod-label branch from 3011319 to f8366d3 Compare September 29, 2025 23:42
@aman0408 aman0408 changed the title feat: Enhance metrics to tag managed_pod in nri_hooks feat: Add noop status to metrics in NRI hooks Sep 30, 2025
@gauravkghildiyal
Copy link
Member

@michaelasp, @aojea I hope the changes and the rationale make sense now. I'll proceed with merging assuming you were fine with the current state. If there's additional changes, we can follow up separately.

@gauravkghildiyal gauravkghildiyal merged commit 51b8a6c into google:main Sep 30, 2025
6 checks passed
@aojea
Copy link
Collaborator

aojea commented Oct 1, 2025

@michaelasp, @aojea I hope the changes and the rationale make sense now. I'll proceed with merging assuming you were fine with the current state. If there's additional changes, we can follow up separately.

it is ok, the logic is not encapsulated into the methods, and we are not spreading the metrics details

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants