This repository was archived by the owner on Dec 9, 2025. It is now read-only.
feat: Replicate host routing rules and tables in pod #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelasp
reviewed
Nov 12, 2025
Collaborator
|
only skimmed during 1 minute but this looks pretty neat |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for replicating host routing rules and routes from non-default routing tables into pod network namespaces, enabling advanced networking configurations like policy-based routing and source-based routing in DRANET.
- Introduces a new
RuleConfigtype to represent routing rules with priority, source/destination CIDRs, and routing table ID - Extends route discovery to include routes from all tables (not just main), and adds rule discovery with interface association logic
- Adds validation, documentation, and end-to-end testing for the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/types.go | Adds RuleConfig type and Table field to RouteConfig |
| pkg/apis/validation.go | Adds validation logic for rules and route table fields |
| pkg/apis/validation_test.go | Adds comprehensive test coverage for rule and route table validation |
| pkg/driver/dra_hooks.go | Implements route discovery from all tables and rule discovery with interface association |
| pkg/driver/netnamespace.go | Implements rule application in pod network namespace |
| pkg/driver/nri_hooks.go | Integrates rule configuration into pod sandbox creation |
| tests/e2e.bats | Adds end-to-end test for rule and route replication |
| site/content/docs/user/interface-configuration.md | Documents the new RuleConfig structure and Table field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
414ae56 to
4312637
Compare
Member
Author
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Thanks for the reviews!
7db1af4 to
b14154e
Compare
michaelasp
reviewed
Nov 26, 2025
Collaborator
|
Overall lgtm! |
michaelasp
previously approved these changes
Nov 26, 2025
This change enables DRANET to discover and replicate host routing rules and routes from non-default tables into the pod's network namespace. Previously, only routes from the main table were copied. This was insufficient for advanced networking configurations that rely on policy-based routing (ip rule) and multiple routing tables (like source based routing) This commit introduces the following changes: - The driver now inspects the host for ip rule entries associated with a network interface. - It also inspects for ip route entries in non-default tables. - These rules and routes are then replicated within the pod's network namespace when it's created. - An end-to-end test has been added to validate this functionality.
b14154e to
6c00b61
Compare
michaelasp
approved these changes
Nov 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables DRANET to discover and replicate host routing rules and routes from non-default tables into the pod's network namespace.
Previously, only routes from the main table were copied. This was insufficient for advanced networking configurations that rely on policy-based routing (ip rule) and multiple routing tables (like source based routing)
This commit introduces the following changes: