-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fragment Mono : 1.010 added #5461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[24] FragmentMono-Italic.ttf💔 ERROR: Check small caps glyphs are available. (com.google.fonts/check/missing_small_caps_glyphs)
🔥 FAIL: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
[23] FragmentMono-Regular.ttf💔 ERROR: Check small caps glyphs are available. (com.google.fonts/check/missing_small_caps_glyphs)
🔥 FAIL: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
QA_images.zip |
|
Thanks @weiweihuanghuang looks very good. I have a conflicted opinion about this fail: 🔥 FAIL: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace) I understand you have plenty of ligatures and this parameter may force the double-width glyphs to appear single-width in some apps, is that correct? Do you think this check needs revision? |
|
Thanks for checking @RosaWagner! Actually I ended up making all the ligature glyphs still conform to the monospaced advanced width but uses substitutions to add blank glyphs after the ligatures that are wider than 1 glyph which is what Fira Code and other coding fonts do. Does the panose need to be set to 9 for monospace? I have it correctly set in the .glyphs file, did fontmake reset it all to 0? |
|
Ah! Then it may not have been put where fontmake looks for it. I think that Fontmake is looking in the font instances custom parameters (and not font info). If this is what you did, then it is the other way around. |
|
Ohh ok that makes sense! I'll update my repo and add my latest files to the PR |
|
New fonts with correct PANOSE information added in e76d937 |
|
Did you run |
|
I did but I haven't run it again since. |
Fontbakery reportFontbakery version: 0.8.10 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[23] FragmentMono-Italic.ttf💔 ERROR: Check small caps glyphs are available. (com.google.fonts/check/missing_small_caps_glyphs)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
[22] FragmentMono-Regular.ttf💔 ERROR: Check small caps glyphs are available. (com.google.fonts/check/missing_small_caps_glyphs)
⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Glyph names are all valid? (com.google.fonts/check/valid_glyphnames)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments] ⚠ WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments] ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
|
Thank you! Can I ask how long it would take for it to show up on https://fonts.google.com/ ? |
|
2 weeks in general, but it happened in the past that it took 2 month, so you have an idea ;) |
Fragment Mono
Fragment Mono is a monospaced coding version of Helvetica created by modifying and extending Nimbus Sans by URW Design Studio.
#5460