This CL relaxes the input type hints to resolve an invariance issue with Python type checkers (Pyright/MyPy). #5187
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL relaxes the input type hints to resolve an invariance issue with Python type checkers (Pyright/MyPy).
Rationale: The current type definition strictly requires dict[str, int]. Because standard dictionaries are invariant, this definition rejects dictionaries keyed by StrEnum, despite StrEnum being a subclass of str.
This forces downstream users to cast their data types or lose type safety. The example below illustrates the false positive error generated by the current signature:
Pyright Error:
Type parameter "_KT@dict" is invariant, but "MyEnum" is not the same as "str"