Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Ruide
Copy link
Collaborator

@Ruide Ruide commented Mar 26, 2024

Add an event-log flag to enable specifying custom event log file location.

@Ruide Ruide requested a review from alexmwu March 26, 2024 17:26
@Ruide Ruide self-assigned this Mar 26, 2024
@Ruide Ruide force-pushed the measurement-file-flag branch from 2f0d9a7 to debff0f Compare March 26, 2024 17:30
Copy link
Contributor

@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not implement this interface:

type EventLogGetter interface {
EventLog() ([]byte, error)
}
?

@Ruide Ruide force-pushed the measurement-file-flag branch from 9f87cef to e5558fc Compare March 26, 2024 19:44
@Ruide
Copy link
Collaborator Author

Ruide commented Mar 26, 2024

Why not implement this interface:

type EventLogGetter interface {
EventLog() ([]byte, error)
}

?

It may add complexity and might make it harder to debug in the future. But sure, I implemented the interface version.

@Ruide
Copy link
Collaborator Author

Ruide commented Mar 26, 2024

/gcbrun

@Ruide Ruide requested a review from alexmwu March 26, 2024 19:49
@Ruide
Copy link
Collaborator Author

Ruide commented Apr 2, 2024

/gcbrun

jkl73
jkl73 previously approved these changes Apr 9, 2024
@jkl73 jkl73 dismissed their stale review April 9, 2024 19:46

request change

@Ruide
Copy link
Collaborator Author

Ruide commented Apr 9, 2024

/gcbrun

@jkl73
Copy link
Contributor

jkl73 commented Apr 9, 2024

Sorry I should ask this earlier: why do we need to have a flag for the eventlog? Do we expect a user to use an eventlog other than the default one?

And seems like all the existing eventlog fetching logic is built around this idea of using the default eventlog. And it's hard to add a flag and proper test without changing a lot of existing eventlog logic.

@Ruide
Copy link
Collaborator Author

Ruide commented Apr 9, 2024

/gcbrun

@Ruide
Copy link
Collaborator Author

Ruide commented Apr 9, 2024

/gcbrun

@Ruide
Copy link
Collaborator Author

Ruide commented Apr 10, 2024

/gcbrun

1 similar comment
@Ruide
Copy link
Collaborator Author

Ruide commented Apr 10, 2024

/gcbrun

@Ruide Ruide force-pushed the measurement-file-flag branch from bb823ab to 6816551 Compare April 10, 2024 01:01
@Ruide
Copy link
Collaborator Author

Ruide commented Apr 10, 2024

/gcbrun

@Ruide Ruide merged commit 2c23b80 into google:main Apr 11, 2024
@Ruide Ruide deleted the measurement-file-flag branch April 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants