-
Notifications
You must be signed in to change notification settings - Fork 85
Add event-log flag to cmd package #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2f0d9a7 to
debff0f
Compare
alexmwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not implement this interface:
go-tpm-tools/client/eventlog.go
Lines 17 to 19 in cf9fd6d
| type EventLogGetter interface { | |
| EventLog() ([]byte, error) | |
| } |
9f87cef to
e5558fc
Compare
It may add complexity and might make it harder to debug in the future. But sure, I implemented the interface version. |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
Sorry I should ask this earlier: why do we need to have a flag for the eventlog? Do we expect a user to use an eventlog other than the default one? And seems like all the existing eventlog fetching logic is built around this idea of using the default eventlog. And it's hard to add a flag and proper test without changing a lot of existing eventlog logic. |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
bb823ab to
6816551
Compare
|
/gcbrun |
Add an event-log flag to enable specifying custom event log file location.