Send client logs with the cloud logging library #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/gcbrun |
4 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
5 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
| if err != nil { | ||
| return fmt.Errorf("failed to convert %v into uint64, got: %v", devShmSizeKey, val) | ||
| } | ||
| s.DevShmSize = int64(size) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
Contributor
Author
|
/gcbrun |
4 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
2 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
jkl73
approved these changes
Oct 22, 2024
Contributor
jkl73
left a comment
There was a problem hiding this comment.
Mostly nits, feel free to submit
Contributor
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces our existing logging (with the "log" package) with a custom logging library that wraps (1) the Cloud Logging library (for logging to Cloud Logs) and (2) slog (for logging to the serial console). Using the Cloud Logging library allows for structured payloads and properly displayed severity (ex. ERROR logs) in the logging UI.
Note this does NOT include logging redirection from the workload - that is still sent via
StdOut(in the case of Cloud Logging).Examples
Cloud Logs
Serial Logs
Breaking Changes
*log.Loggertype tologging.Loggerinagent.CreateAttestationAgent(),agent.fetchContainerimageSignatures(),ContainerRunner.logger,runner.NewRunner(),spec.GetLaunchSpec(),spec.fetchExperiments(), andteeserver.New()