Support health monitoring mode for NPD #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/gcbrun |
4 similar comments
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
alexmwu
approved these changes
Oct 11, 2024
Contributor
alexmwu
left a comment
There was a problem hiding this comment.
Great work! Mostly minor comments except about the struct to json encoding.
launcher/internal/healthmonitoring/nodeproblemdetector/systemstats_config.go
Outdated
Show resolved
Hide resolved
launcher/internal/healthmonitoring/nodeproblemdetector/systemstats_config.go
Show resolved
Hide resolved
launcher/launcher/main.go
Outdated
| if launchSpec.MonitoringEnabled == spec.All { | ||
| logger.Printf("All health monitoring metrics enabled") | ||
| if err := nodeproblemdetector.EnableAllConfig(); err != nil { | ||
| logger.Printf("failed to enable full monitoring config: %v", err) |
Contributor
There was a problem hiding this comment.
Since it's logged, this should be capitalized "Failed to ...
Contributor
Author
|
/gcbrun |
Contributor
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the full list of system stat metrics that can be collected by NPD for health monitoring. The full configuration will be enabled if allowed by the policy and spec.
Breaking Changes
spec.GetLaunchPolicy(imageLabels map[string]string)tospec.GetLaunchPolicy(imageLabels map[string]string, logger *log.Logger)