Prevent simulator from returning TPM_RC_RETRY #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For certain TPM2 commands like ActivateCredential or PolicySecret, the TPM is allowed to return TPM_RC_RETRY. In this simulator, this occurs when dictionary attack prevention mechanisms are used. Specifically, when checking to see if the maximum number of tries has been exceeded, the simulator returns TPM_RC_RETRY to let certain values sync to nvdata. While this can occur on real TPMs as well, it tends not to, and go-tpm does not automatically handle this case. So we simply remove the above feature.
twitchy-jsonp
approved these changes
Dec 22, 2018
josephlr
pushed a commit
to josephlr/go-tpm-tools
that referenced
this pull request
Jul 3, 2019
taking latest from parent repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For certain TPM2 commands like ActivateCredential or PolicySecret, the
TPM is allowed to return TPM_RC_RETRY. In this simulator, this occurs
when dictionary attack prevention mechanisms are used. Specifically,
when checking to see if the maximum number of tries has been exceeded,
the simulator returns TPM_RC_RETRY to let certain values sync to nvdata.
While this can occur on real TPMs as well, it tends not to, and go-tpm
does not automatically handle this case. So we simply remove the above
feature.