Integration of go-tpm-tools with go-tdx-guest #347

Pranjali-2501 · 2023-08-18T04:48:37Z

When getting a vTPM quote within a TDX VM, the attestation service will utilize go-tdx-guest to generate and verify Intel's TDX hardware based attestation quote.

Add TDX attestation protobuf in the go-tpm-tools attestation message.
Update client changes for TDX device-related attestation quote generation.
Update server changes for TDX quote verification using go-tdx-guest.
Enhance CLI tool for TDX functionality updates.

google-cla · 2023-08-18T04:48:41Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

proto/attest.proto

cmd/verify.go

go.mod

deeglaze · 2023-08-18T15:59:36Z

server/verify.go

 	case pb.GCEConfidentialTechnology_AMD_SEV: // Not verifiable on GCE
 		return nil
 	case pb.GCEConfidentialTechnology_AMD_SEV_ES: // Not verifiable on GCE
 		return nil


return an error if opts is non-nil for all NONE, SEV, and SEV_ES cases. Add a test case for that expecting to verify SEV-SNP on SEV is an error.

I have implemented the changes for NONE, SEV and SEV-ES.
For test :
It tries to parse the Eventlog to get the value for state.Platform.GetTechnology().
for testing we need to modify this. Is it possible?

BTW I have already added a test when --tee_technology flag is set to sev, instead of sev-snp in cmd/attest_test.go .
Error in this case would be tee-technology should be either empty or should have values sev-snp or tdx

I don't know what possibility you're asking for. I'll defer to Alex.

IIUC, it will detect the hardware technology enabled on the cvm by itself only.

server/verify.go

jkl73 · 2023-08-24T23:05:22Z

client/attest.go

+func (d *TdxDevice) AddAttestation(attestation *pb.Attestation, opts AttestOpts) error {
+	var tdxNonce [tabi.TdReportDataSize]byte
+	if len(opts.TEENonce) == 0 {
+		copy(tdxNonce[:], opts.Nonce[:])


opts.Nonce is already a slice, so I think [:] is not needed

Also do we care about the size of opts.Nonce (what if it's zero)?

Nonce can not be zero. Check for this is already there

if len(opts.Nonce) == 0 { return nil, fmt.Errorf("provided nonce must not be empty") }

nonce can be of any size. For teenonce the size is fixed.

Yes, slicing is not required. I have changed it.

Okay, looks a little bit weird to me because the tdxNonce can be only the first part of the opt.Nonce (may result not enough entropy for the nonce?). I'm not sure maybe @deeglaze and @alexmwu can confirm if it's okay.

I have tested the implementation and it is working fine.

And for copy(tdxNonce[:], opts.Nonce[:]) , if length of nonce is less that 64 then it will concatenate zeros at the end.

If the user does not provide a teenonce, then the nonce will be used as the teenonce, either concatenated with zeroes or truncated to make it 64 bytes long.

But If teenonce is present, then it must be 64 bytes in length.

jkl73 · 2023-08-24T23:21:32Z

proto/gen_attest.sh

 #!/bin/bash

-protoc -I. -I`go list -m -f "{{.Dir}}" github.com/google/go-sev-guest` --go_out=. --go_opt=module=github.com/google/go-tpm-tools/proto attest.proto
+protoc -I. -I`go list -m -f "{{.Dir}}" github.com/google/go-sev-guest` -I`go list -m -f "{{.Dir}}" github.com/google/go-tdx-guest` --go_out=. --go_opt=module=github.com/google/go-tpm-tools/proto attest.proto


nit: newline EOF

There is no new line at the EOF.
Do you want me to add a blank line?

yes, because I think the original file has a new line at the end

go.mod

jkl73

lgtm

jkl73 · 2023-08-25T23:05:32Z

proto/gen_attest.sh

 #!/bin/bash

-protoc -I. -I`go list -m -f "{{.Dir}}" github.com/google/go-sev-guest` --go_out=. --go_opt=module=github.com/google/go-tpm-tools/proto attest.proto
+protoc -I. -I`go list -m -f "{{.Dir}}" github.com/google/go-sev-guest` -I`go list -m -f "{{.Dir}}" github.com/google/go-tdx-guest` --go_out=. --go_opt=module=github.com/google/go-tpm-tools/proto attest.proto


yes, because I think the original file has a new line at the end

jkl73 · 2023-08-25T23:09:48Z

client/attest.go

+func (d *TdxDevice) AddAttestation(attestation *pb.Attestation, opts AttestOpts) error {
+	var tdxNonce [tabi.TdReportDataSize]byte
+	if len(opts.TEENonce) == 0 {
+		copy(tdxNonce[:], opts.Nonce[:])


Okay, looks a little bit weird to me because the tdxNonce can be only the first part of the opt.Nonce (may result not enough entropy for the nonce?). I'm not sure maybe @deeglaze and @alexmwu can confirm if it's okay.

New Features: [launcher] Verify FS and mount before launch google#311 Integration of go-tpm-tools with go-tdx-guest google#347 Intra-version Breaking Changes: Add launcherfile package for path and file consts google#356 breaks google#333 Bug Fixes: [launcher] Update the token refresh logic google#325 [launcher] Fix logging blocking issue google#338 Other Changes: [launcher] Add a new metadata flag of signedImageRepos google#320 Update go-sev-guest to v0.7.0 google#329 [launcher] Add SSH test for image. google#314 Add supported architectures to ci.yml google#330 Fix the go version number error google#326 [launcher] Signature discovery: fetch a signed image manifest at for parsing google#324 [launcher] Export attestation token filepath and filename google#333 [launcher] Increase the max file descriptor google#339 [launcher] Add a signature interface and a library to parse signature from image manifest google#328 Rename TdxVerify function to TdxQuote in server package. google#353 [launcher] Use V1 SDK in launcher verifier client google#305 Update and tidy dependencies google#344

New Features: [launcher] Verify FS and mount before launch #311 Integration of go-tpm-tools with go-tdx-guest #347 Intra-version Breaking Changes: Add launcherfile package for path and file consts #356 breaks #333 Bug Fixes: [launcher] Update the token refresh logic #325 [launcher] Fix logging blocking issue #338 Other Changes: [launcher] Add a new metadata flag of signedImageRepos #320 Update go-sev-guest to v0.7.0 #329 [launcher] Add SSH test for image. #314 Add supported architectures to ci.yml #330 Fix the go version number error #326 [launcher] Signature discovery: fetch a signed image manifest at for parsing #324 [launcher] Export attestation token filepath and filename #333 [launcher] Increase the max file descriptor #339 [launcher] Add a signature interface and a library to parse signature from image manifest #328 Rename TdxVerify function to TdxQuote in server package. #353 [launcher] Use V1 SDK in launcher verifier client #305 Update and tidy dependencies #344

Pranjali-2501 and others added 4 commits July 12, 2023 10:17

client integration with go-tdx-guest

fe66166

Merge branch 'google:master' into master

e1cfe2a

Integration of go-tpm-tools with go-tdx-guest

ae56540

modify tdx/sev-snp tests in cmd

c19f9f9

deeglaze suggested changes Aug 18, 2023

View reviewed changes

Pranjali-2501 added 2 commits August 21, 2023 09:50

add checks to verify TEEopts in case of NONE, SEV and SEV_ES

c72a946

change protoc-gen-go version

6e34815

deeglaze reviewed Aug 21, 2023

View reviewed changes

server/verify.go Outdated Show resolved Hide resolved

update go-tdx-guest version

282adc4

Pranjali-2501 requested review from deeglaze August 24, 2023 04:05

jkl73 reviewed Aug 24, 2023

View reviewed changes

Pranjali-2501 added 2 commits August 25, 2023 04:53

modify protobuf version

04e0993

version updated

d4cf36f

jkl73 reviewed Aug 25, 2023

View reviewed changes

minor changes

1c6b269

jkl73 approved these changes Aug 28, 2023

View reviewed changes

jkl73 merged commit 884b941 into google:master Aug 28, 2023

alexmwu mentioned this pull request Sep 15, 2023

Release v0.4.1 #357

Merged

Integration of go-tpm-tools with go-tdx-guest #347

Integration of go-tpm-tools with go-tdx-guest #347

Uh oh!

Conversation

Pranjali-2501 commented Aug 18, 2023

Uh oh!

google-cla bot commented Aug 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jkl73 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants