chore: Use go:fix inline for deprecated ptr funcs#4034
Merged
gmlewis merged 2 commits intogoogle:masterfrom Feb 25, 2026
Merged
chore: Use go:fix inline for deprecated ptr funcs#4034gmlewis merged 2 commits intogoogle:masterfrom
go:fix inline for deprecated ptr funcs#4034gmlewis merged 2 commits intogoogle:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4034 +/- ##
==========================================
- Coverage 94.10% 94.08% -0.02%
==========================================
Files 207 207
Lines 19207 19207
==========================================
- Hits 18074 18071 -3
- Misses 935 938 +3
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
go:fix inline for deprecated ptr funcs
gmlewis
approved these changes
Feb 25, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bool,Int,Int64, andStringwere replaced byPtrin #3355. This PR adds//go:fix inlinedirective to these functions, allowing users to replace the deprecated ones across the codebase using the simple command:See https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/inline#hdr-Analyzer_inline