Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

Also, please make sure to run go generate ./... as described in our CONTRIBUTING.md guide.

You will want to commit/push (not force-push) the changes to the PR once you run go generate ./....

Hmmm... it looks like my go generate ./... code is breaking the tests... sorry about that @derekjobst - let me investigate.

I got caught up on Stringify returning a string with the empty Permissions{} in it when Team is converted to a string.

This was easy to fix in strings_test, but the auto-generated github-stringify tests for TestTeam_String refer to a parent team, which does not include the empty Permissions in the string.

It seems like the best solution might be to have the stringifyValue function in strings.go omit empty Permissions.

I've reverted the pointer change to get tests passing — happy to change back if we'd like to change the stringify methods

Codecov Report

Merging #1864 (66fa351) into master (b1b5e4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1864   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6769     6769           
=======================================
  Hits         6610     6610           
  Misses         86       86           
  Partials       73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b5e4e...66fa351. Read the comment docs.

I've reverted the pointer change to get tests passing — happy to change back if we'd like to change the stringify methods

OK, excellent. I've gone ahead and created #1865 and #1866 to address this.

@gmlewis do you know when we might be able to get this into a release? It looks like there are a few other changes since the last one :)

@derekjobst - here you go: https://github.com/google/go-github/releases/tag/v35.2.0