Add test for JSON marshaling for Teams#1941
Conversation
a0d9ee7 to
9528b39
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @emiscode !
LGTM.
In future PRs, please do not use force-push, as it makes it more difficult to review changes made since the last code review. We always use squash-and-merge in this repo, so you can push as many commits as necessary, and they will be merged into one final commit.
Awiating second LGTM before merging.
gmlewis
left a comment
There was a problem hiding this comment.
Whups, it looks like the code needs to be run through gofmt first, in order for the tests to pass. Please fix.
- Adjusted commit as per reviewer feedback and run go fmt
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 105 105
Lines 6786 6786
=======================================
Hits 6627 6627
Misses 86 86
Partials 73 73 Continue to review full report at Codecov.
|
|
Thank you @gmlewis! I'm glad to be contributing to this project, and I really appreciated your care with details during your review process. |
Resource covered: Teams