fix!: Add ListSCIMProvisionedGroupsForEnterpriseOptions#3601
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jun 25, 2025
Merged
Conversation
d13fa0a to
a019a66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3601 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 184 184
Lines 16143 16146 +3
=======================================
+ Hits 14742 14745 +3
Misses 1227 1227
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Jun 25, 2025
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
@alexandear - will you need a new release once this gets merged? I know we just had one, but I'm totally fine with bumping the release since this just missed that one.
Contributor
Author
|
Thanks for checking! I don’t need a new release - happy to wait for the next one. |
a019a66 to
da02fed
Compare
Contributor
Author
|
Rebased to resolve conflicts. |
Collaborator
|
Thank you, @stevehipwell! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ListSCIMProvisionedGroupsForEnterprisenow takesListSCIMProvisionedGroupsForEnterpriseOptionsinstead of*ListSCIMProvisionedIdentitiesOptions.This PR fixes two issues:
ListSCIMProvisionedGroupsForEnterprisewere not beeing handled.ListSCIMProvisionedIdentitiesOptionswas missing theexcludedAttributesproperty.See https://docs.github.com/en/enterprise-cloud@latest/rest/enterprise-admin/scim?apiVersion=2022-11-28#list-provisioned-scim-groups-for-an-enterprise--parameters