fix: Use correct type for custom property default value#3928
Merged
gmlewis merged 7 commits intogoogle:masterfrom Jan 20, 2026
Merged
fix: Use correct type for custom property default value#3928gmlewis merged 7 commits intogoogle:masterfrom
gmlewis merged 7 commits intogoogle:masterfrom
Conversation
Signed-off-by: Steve Hipwell <[email protected]>
Collaborator
|
cc: @tstollin |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3928 +/- ##
==========================================
- Coverage 92.45% 92.44% -0.01%
==========================================
Files 203 203
Lines 14949 14960 +11
==========================================
+ Hits 13821 13830 +9
- Misses 926 927 +1
- Partials 202 203 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Jan 20, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @tstollin
gmlewis
reviewed
Jan 20, 2026
gmlewis
requested changes
Jan 20, 2026
Contributor
Author
|
This should be ready to be merged. |
gmlewis
approved these changes
Jan 20, 2026
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Contributor
Author
|
@alexandear any chance of a review? |
alexandear
approved these changes
Jan 20, 2026
Collaborator
|
Thank you, @alexandear! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3926