Added binPrefix option, to support running via Bazel #653
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have another pull request with a similar purpose at #654. Is there any chance that the change I proposed is suitable for the use-case that you have, please? |
|
Not entirely sure; Bazel is very particular about dependency paths
…On Thu, Jul 22, 2021 at 1:33 PM Richard Barrell ***@***.***> wrote:
I have another pull request with a similar purpose at #654
<#654>. Is there any chance that the
change I proposed is suitable for the use-case that you have, please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#653 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALOBK63ARRO2BJ7FIKNMKLTY7XYDANCNFSM5AHPTQUA>
.
|
|
Rats. I was hoping that it would be easy for Bazel users to arrange to add the eslint dir to $PATH. |
|
ping @JustinBeckwith :) |
alexander-fenster
approved these changes
Jun 16, 2022
|
@dorfire It's been almost a year but here we go, let's finally merge it :) Would you mind signing the CLA so that we could accept your PR? |
|
I can help push this into a release if we can resolve the conflicts |
|
Not sure this change is necessary any longer. @dorfire can you comment on this being necessary still? Otherwise, will close out the PR as out of date. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.