Clear the fields of a Node inside delete.
#8132
Merged
+58
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we don't retain memory to other `Node` instances and their contents, even in unlikely scenarios in which the user is holding a reference to one specific `Node` (through an `Entry`) but not to the others that it refers to. This requires reading those fields in advance when replacing a node. But given that we already had complex ordering rules to follow in `putInverse`, I think that this is an improvement. (This change was prompted by investigation in 2097440.) RELNOTES=n/a PiperOrigin-RevId: 846336997
4b59b1d to
06376ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the fields of a
Nodeinsidedelete.This ensures that we don't retain memory to other
Nodeinstances and their contents, even in unlikely scenarios in which the user is holding a reference to one specificNode(through anEntry) but not to the others that it refers to.This requires reading those fields in advance when replacing a node. But given that we already had complex ordering rules to follow in
putInverse, I think that this is an improvement.(This change was prompted by investigation in 2097440.)
RELNOTES=n/a