Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tcpip: fix IP_MTU_DISCOVER flag for tcp and udp #12366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
copybara-service merged 1 commit into from
Jan 9, 2026
Merged

tcpip: fix IP_MTU_DISCOVER flag for tcp and udp #12366

copybara-service merged 1 commit into from
Jan 9, 2026
+57 −43

Conversation

@pkit
Copy link
Contributor

@pkit pkit commented Dec 10, 2025

Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support tracepath actually tracing the path the correct propagation of TTL exceeded is needed.

@ayushr2 ayushr2 requested a review from milantracy December 10, 2025 09:27
@milantracy
Copy link
Contributor

milantracy commented Dec 15, 2025

@pkit thanks!

copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
9e2078e 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844523992
@copybara-service copybara-service bot mentioned this pull request Dec 15, 2025
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
[Patched] tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
851e580 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844587171
@copybara-service copybara-service bot mentioned this pull request Dec 15, 2025
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
c194ce7 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844591169
@copybara-service copybara-service bot mentioned this pull request Dec 15, 2025
Open
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
afd30c6 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844591169
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
8510521 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844591169
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
d5956ff 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844591169
milantracy
milantracy requested changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@milantracy milantracy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just realize that you will need to update the test cases at
https://github.com/google/gvisor/blob/master/test/syscalls/linux/tcp_socket.cc#L2360-L2373

@pkit
Copy link
Contributor Author

pkit commented Dec 15, 2025

@milantracy cool! I will.

copybara-service bot pushed a commit that referenced this pull request Dec 18, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
4c2ed97 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844523992
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
2e32156 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844523992
copybara-service bot pushed a commit that referenced this pull request Dec 18, 2025
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
fb7d4b8 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162
PiperOrigin-RevId: 844523992
@pkit pkit force-pushed the pmtu_probe_support branch from 5ca5162 to 7a98393 Compare December 21, 2025 20:22
@pkit
Copy link
Contributor Author

pkit commented Dec 21, 2025

@milantracy changed the test. altered some stale comments. added some more locks.

copybara-service bot pushed a commit that referenced this pull request Jan 5, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
bbccde4 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
@copybara-service copybara-service bot mentioned this pull request Jan 5, 2026
Closed
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
f22f132 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
53be346 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
ac04a2b 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
f0a3c5a 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
f3fecf9 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
af059d5 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
0be7271 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
copybara-service bot pushed a commit that referenced this pull request Jan 9, 2026
@pkit @gvisor-bot
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
e550acf 
Fixes #12319

This patch only supports various IP_MTU_DISCOVER flags.
To fully support `tracepath` actually tracing the path the correct propagation of TTL exceeded is needed.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 7a98393
PiperOrigin-RevId: 852444549
@copybara-service copybara-service bot merged commit 991e79d into google:master Jan 9, 2026
6 checks passed
@ayushr2
Copy link
Collaborator

ayushr2 commented Jan 12, 2026

@pkit this change broke some Java runtime tests: https://buildkite.com/gvisor/pipeline/builds/39649. We are rolling it back. Please have a look.

@avagin
Copy link
Collaborator

avagin commented Jan 12, 2026

This change broke java runtime tests: #12479

@avagin
Copy link
Collaborator

avagin commented Jan 12, 2026

#12480 will roll back this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milantracy milantracy milantracy requested changes

Assignees

No one assigned

Labels

ready to pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support IP_MTU_DISCOVER

4 participants

@pkit @milantracy @ayushr2 @avagin