checklocks: move checklocksalias to type #12459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ayushr2 another one for you. |
c56378f to
57b6f50
Compare
Repurpose checklocksalias as a type-level annotation so alias relationships are declared once per type instead of per call. Update tcp/ipv4 annotations accordingly and drop per-call workarounds. Enhance checklocksfail to allow substring matching so that robust tests for checklocksalias are possible.
57b6f50 to
22d8b34
Compare
Contributor
Author
|
Ping. This PR is a really nice improvement IMO because it centralizes and greatly reduces the number of alias annotations needed in the presence of circular references. |
avagin
reviewed
Jan 12, 2026
|
|
||
| // +checklocks:ep.mu | ||
| func newSender(ep *Endpoint, iss, irs seqnum.Value, sndWnd seqnum.Size, mss uint16, sndWndScale int) *sender { | ||
| func initSender(ep *Endpoint, iss, irs seqnum.Value, sndWnd seqnum.Size, mss uint16, sndWndScale int) { |
Collaborator
There was a problem hiding this comment.
why do we need to do that in this patch?
Contributor
Author
There was a problem hiding this comment.
Because otherwise we have a floating sender that isn't attached to the endpoint, so checklocks can't see that the mutex is the same.
kakkoyun
approved these changes
Jan 15, 2026
kakkoyun
left a comment
There was a problem hiding this comment.
LGTM. This is a great improvement! Looking forward to having this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repurpose checklocksalias as a type-level annotation so alias
relationships are declared once per type instead of per call. Update
tcp/ipv4 annotations accordingly and drop per-call workarounds.
Enhance checklocksfail to allow substring matching so that robust tests
for checklocksalias are possible.