Refactor runsc shim to move container specific logic out of task service. #12489
+362
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e070b63 to
eb40bfc
Compare
…ice. The change unblocks implementing features like shim grouping and shim migration. It also more aligns with the runc implementation, which makes it easier for the future integrations with containerd. PiperOrigin-RevId: 856891174
eb40bfc to
eca1f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor runsc shim to move container specific logic out of task service.
The change unblocks implementing features like shim grouping and shim migration.
It also more aligns with the runc implementation, which makes it easier for
the future integrations with containerd.