Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Nov 12, 2025

Found via codespell -S *.json,*.lock,tests_data -L hve,afterall and typos --hidden --format brief

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a number of typos across the codebase. The changes are mostly correct. I've found a couple of minor issues:

  • In python/scripts/test_magika_model.py, a typo was fixed but replaced with another incorrect word. I've suggested a fix.
  • In python/CHANGELOG.md, the numbering of a list is inconsistent, which I've pointed out for better readability.

Overall, good catch on the typos!

@reyammer
Copy link
Collaborator

Thanks! This touches many files, and I'll first need to update the versioning of the packages as well. I'll get to it.

BTW, is the git diff coming from just using those tools above automatically, or you used the tools and then you manually checked what were reasonable findings? I'm wondering whether we could add these commands as part of our CI...

@kianmeng
Copy link
Contributor Author

Thanks! This touches many files, and I'll first need to update the versioning of the packages as well. I'll get to it.

Noted.

BTW, is the git diff coming from just using those tools above automatically, or you used the tools and then you manually checked what were reasonable findings? I'm wondering whether we could add these commands as part of our CI...

Manually check one by one, as suggested by the tools. Corrections were applied based on my understanding of the context or intended usage of the doc/code.

Copy link
Collaborator

@reyammer reyammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment's on gemini's feedback. Thanks!

Found via `codespe -S *.json,*.lock,tests_data -L hve,afterall` and `typos
--hidden --format brief`
@kianmeng
Copy link
Contributor Author

See my other comment's on gemini's feedback. Thanks!

@reyammer Done. See 7016456 and 4dceefe

@kianmeng kianmeng requested a review from reyammer January 18, 2026 14:57
@reyammer reyammer merged commit d48d5f0 into google:main Jan 21, 2026
90 checks passed
@reyammer
Copy link
Collaborator

Merged, thanks so much!

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants