-
Notifications
You must be signed in to change notification settings - Fork 483
Fix typos #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #1240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a number of typos across the codebase. The changes are mostly correct. I've found a couple of minor issues:
- In
python/scripts/test_magika_model.py, a typo was fixed but replaced with another incorrect word. I've suggested a fix. - In
python/CHANGELOG.md, the numbering of a list is inconsistent, which I've pointed out for better readability.
Overall, good catch on the typos!
|
Thanks! This touches many files, and I'll first need to update the versioning of the packages as well. I'll get to it. BTW, is the git diff coming from just using those tools above automatically, or you used the tools and then you manually checked what were reasonable findings? I'm wondering whether we could add these commands as part of our CI... |
Noted.
Manually check one by one, as suggested by the tools. Corrections were applied based on my understanding of the context or intended usage of the doc/code. |
reyammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment's on gemini's feedback. Thanks!
|
Merged, thanks so much! |
|
🥳 🥳 🥳 🥳 🥳 |
Found via
codespell -S *.json,*.lock,tests_data -L hve,afterallandtypos --hidden --format brief