fix potentially missing some signals when --forward_signals is set #241
Conversation
previously code dealing with sigFatal assumed that the value is either 0 or a value representing a single type of signal
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| } else { | ||
| removeProc(nsjconf, pid); | ||
| } | ||
| kill(pid, signal); |
There was a problem hiding this comment.
i think this is a mistake.. if kill returns 0 we should call removeProc otherwise we'll sit here forever
|
@robertswiecki i think this does need a real good looking at before its accepted - consider that its really not tested and just suggestion about how the underlying issue could be fixed i think i haven't really properly understood the function of killAndReapAll - the issue i tried to fix was that we want to be able to forward multiple signals to a process without the first signal resulting in a call to reapProc |
previously code dealing with sigFatal assumed that the value is either 0 or a value representing a single type of signal