Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix checkpoint policy for Grok #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix checkpoint policy for Grok #76

wants to merge 4 commits into from

Conversation

@hx89
Copy link
Contributor

@hx89 hx89 commented Jun 18, 2024 •
edited
Loading

Fix two issues:

  1. Checkpoint policy is not passed into Grok PP
  2. Bug in praxis attention layer, causing qkv proj output not checkpointed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hx89