Error for missing README #42

gdsotirov · 2017-06-29T18:57:18Z

Should not this rule produce README, instead of README.tmp? Otherwise, I receive the following error:

cat README.md > README.tmp
 /usr/bin/mkdir -p '/usr/src/tmp/package-snappy/usr/doc/snappy-1.1.5'
 /usr/bin/ginstall -c -m 644 ChangeLog COPYING INSTALL NEWS ./README format_description.txt framing_format.txt '/usr/src/tmp/package-snappy/usr/doc/snappy-1.1.5'
/usr/bin/ginstall: cannot stat './README': No such file or directory
Makefile:767: recipe for target 'install-dist_docDATA' failed
make[1]: *** [install-dist_docDATA] Error 1
make[1]: Leaving directory '/usr/src/tmp/snappy-1.1.5'
Makefile:1230: recipe for target 'install-am' failed
make: *** [install-am] Error 2

Should not this rule produce README, instead of README.tmp? Otherwise, I receive the following error: `cat README.md > README.tmp /usr/bin/mkdir -p '/usr/src/tmp/package-snappy/usr/doc/snappy-1.1.5' /usr/bin/ginstall -c -m 644 ChangeLog COPYING INSTALL NEWS ./README format_description.txt framing_format.txt '/usr/src/tmp/package-snappy/usr/doc/snappy-1.1.5' /usr/bin/ginstall: cannot stat './README': No such file or directory Makefile:767: recipe for target 'install-dist_docDATA' failed make[1]: *** [install-dist_docDATA] Error 1 make[1]: Leaving directory '/usr/src/tmp/snappy-1.1.5' Makefile:1230: recipe for target 'install-am' failed make: *** [install-am] Error 2`

googlebot · 2017-06-29T18:57:20Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

gdsotirov · 2017-06-29T20:05:41Z

I signed it!

googlebot · 2017-06-29T20:05:45Z

CLAs look good, thanks!

gdsotirov · 2017-07-12T06:30:55Z

The problem with Autotools in 1.1.5 is also that SO version is 0.4.1 (i.e. libsnappy.so.0.4.1), which breaks existing run-time dependencies that relay on libsnappy.so.1 link to be present.

bjori · 2017-07-12T22:40:58Z

Makefile.am


 # Needed by autoconf because we use README.md instead of README.
 # See http://stackoverflow.com/q/15013672/
 README: README.md


shouldn't this rule be removed and the README in dist_doc_DATA be renamed README.md?

Autoconf and Linux distributions require just README (without .md, .txt or other extension).

My bad. autogen.sh would also need to be updated to pass --foreign to automake to stop it from complaining about the names.
These are very silly warnings anyway.

djsutherland · 2017-07-20T21:31:13Z

👍 Needed to add this to conda-forge/snappy-feedstock#11 to build snappy there.

pwnall · 2017-07-31T17:59:40Z

Thank you very much for the PR! We "fixed the glitch" by removing autoconf support. I hope CMake will be a less bumpy ride, once we settle on a configuration that works for everyone.

gdsotirov · 2017-07-31T18:01:52Z

Sure, but please, consider adding the option to set LIBDIR with CMake, because it's important.

pwnall · 2017-07-31T19:23:26Z

@gdsotirov Can you please create a PR or comment on the relevant PR?

gdsotirov · 2017-08-01T05:59:08Z

@pwnall I do not have a patch for LIBDIR support, because I'm not that familiar with CMake yet, so I've solved the problem by just renaming the directory after make install :-) Still it's good to consider for next version. Where can I raise an issue, because here on GitHub I do not see this option?

pwnall · 2017-08-01T18:38:30Z

@gdsotirov I think we don't have Issues enabled because we're struggling to just keep up the pace with the PRs... at this rate, issues would just get ignored. Let's continue the discussion here for now -- I thought LIBDIR was discussed somewhere in the open PRs, but that doesn't seem to be the case.

I'm still catching up on CMake, and I'm wary of adding unnecessary complexity to our CMakeLists. To this end, I'd be more interested in the reasoning behind a change, and the sources advocating for it.

In this specific example, I'd like to know what problems are solved by exposing a LIBDIR variable, and why that's not advocated in CMake's packaging guide. Yesterday, the GNUInstallDirs was brought to my attention. It seems like it'd solve the LIBDIR problem, but I haven't had time to look into why it's not recommended in the packaging guide.

gdsotirov · 2017-08-02T11:06:01Z

@pwnall OK about issues.

Exposing the possibility to set LIBDIR is important for distribution packages like me, because the library directory for a true 64 bit OS like Slackware64 is /usr/lib64, so I need to set it properly for installation. With autotools it was possible to set LIBDIR (e.g. I was managing it with ./configure --libdir=/usr/lib${LIBDIRSUFFIX}), so I believe the lack of possibility with CMake is a regression, that needs to be fixed. I build other library packages with CMake and they all provide the possibility to set LIBDIR.

Optiligence · 2017-08-02T11:12:06Z

What do other CMake projects use to achieve this, do they use GNUInstallDirs, specify custom variables themselves, or something else?
I don’t like that DESTINATION has to be manually set for install(TARGETS) and doesn’t have sane (and configurable) defaults instead.

gdsotirov · 2017-08-02T11:12:51Z

BTW I see Gentoo packages have already elaborated on such patch for Snappy 1.1.6 (see snappy-1.1.6-0001-cmake-Use-GNUInstallDirs-to-provide-configurable-cor.patch).

And they also have the same patch as my PR #44 (see https://gitweb.gentoo.org/repo/gentoo.git/tree/app-arch/snappy/files/snappy-1.1.6-0003-cmake-Add-missing-linking-to-GTEST_LIBRARIES.patch).

I still believe that both are necessary, but as I'm not that familiar with CMake, I haven't suggested a fix for LIBDIR problem and dealt with it by just renaming the directory after install.

gdsotirov · 2017-08-02T11:27:43Z

@Optiligence I cannot say, but for example for libproxy I use cmake -DLIB_INSTALL_DIR=... and for libgme its cmake -DLIB_SUFFIX=..., so you could check what they use if you want.

pwnall · 2017-08-03T10:49:29Z

This is also being discussed in google/googletest#1141. I'm heavily inclined to adopt googletest's decision for fixing this problem.

Optiligence · 2017-08-03T11:36:10Z

The missing RUNTIME DESTINATION, LIBRARY DESTINATION und ARCHIVE DESTINATION also currently install the *.dll to the lib directory. +1 for GNUInstallDirs.

gdsotirov · 2017-08-03T14:22:40Z

Whatever gives me the possibility to set properly LIBDIR is OK for me and Gentoo packages have already implemented GNUInstallDirs, so +1 for GNUInstallDirs from me as well :-)

pwnall · 2017-08-17T04:03:29Z

@gdsotirov @Optiligence Can you please check master and see if the GNUInstallDirs solution meets your needs?

gdsotirov · 2017-08-25T13:35:44Z

@pwnall Sorry, for the delay. I just checked the freshly released Snappy 1.1.7 and I confirm it's OK with the new option CMAKE_INSTALL_LIBDIR. Thanks!

pwnall · 2017-08-25T19:17:09Z

@gdsotirov Thank you very much for the response!

gdsotirov mentioned this pull request Jul 12, 2017

Set both VERSION and SOVERSION for target snappy #45

Closed

bjori reviewed Jul 12, 2017

View reviewed changes

djsutherland mentioned this pull request Jul 20, 2017

fix autoconf README.md workaround #46

Closed

pwnall closed this Jul 31, 2017

pwnall mentioned this pull request Aug 3, 2017

Implement GNUInstallDirs; Add option to skip installation google/googletest#1141

Closed

Error for missing README #42

Error for missing README #42

Uh oh!

Conversation

gdsotirov commented Jun 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jun 29, 2017

Uh oh!

gdsotirov commented Jun 29, 2017

Uh oh!

googlebot commented Jun 29, 2017

Uh oh!

gdsotirov commented Jul 12, 2017

Uh oh!

bjori Jul 12, 2017

Choose a reason for hiding this comment

Uh oh!

gdsotirov Jul 13, 2017

Choose a reason for hiding this comment

Uh oh!

bjori Jul 20, 2017

Choose a reason for hiding this comment

Uh oh!

djsutherland commented Jul 20, 2017

Uh oh!

pwnall commented Jul 31, 2017

Uh oh!

gdsotirov commented Jul 31, 2017

Uh oh!

pwnall commented Jul 31, 2017

Uh oh!

gdsotirov commented Aug 1, 2017

Uh oh!

pwnall commented Aug 1, 2017

Uh oh!

gdsotirov commented Aug 2, 2017

Uh oh!

Optiligence commented Aug 2, 2017

Uh oh!

gdsotirov commented Aug 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gdsotirov commented Aug 2, 2017

Uh oh!

pwnall commented Aug 3, 2017

Uh oh!

Optiligence commented Aug 3, 2017

Uh oh!

gdsotirov commented Aug 3, 2017

Uh oh!

pwnall commented Aug 17, 2017

Uh oh!

gdsotirov commented Aug 25, 2017

Uh oh!

pwnall commented Aug 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gdsotirov commented Jun 29, 2017 •

edited

Loading

gdsotirov commented Aug 2, 2017 •

edited

Loading