static/shared import dispatch based on BUILD_SHARED_LIBS #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. the imported target name from Snappy::snappy to Snappy::Snappy as is general practice
`DESTINATION lib` in `install(TARGETS)` was also installing DLLs to lib it also allows configuration in contrast to hard coded values
allows to install shared and static builds on top of each other using different export names and dispatch in SnappyConfig with the ability (not requirement) to link to a static or shared variant explicitly as goal in mind the following approaches are unsuitable: - populating a variable in SnappyConfig or in downstream projects → prevents errors as per [0] - creating an alias target for one of the imported targets → currently not allowed [1] - manually creating a default imported target and populating all necessary properties → bad for maintenance [0] https://cmake.org/cmake/help/latest/policy/CMP0028.html [1] https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries
Contributor
|
@googlebot rescan |
Member
|
Thank you for your contribution! We're not currently interested in contributions to the build configuration. We now have a paragraph explaining the situation in https://github.com/google/snappy/blob/master/README.md#contributing-to-the-snappy-project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes installation directories (using
GNUInstallDirs) because I didn’t want to commit on top of to-be-fixed code (or create conflicting/interdependent PRs).