This repository was archived by the owner on Mar 1, 2022. It is now read-only.
extract version from Dockerfile#504
Merged
alexander-fenster merged 2 commits intomasterfrom Sep 27, 2018
Merged
Conversation
pongad
reviewed
Sep 26, 2018
pongad
approved these changes
Sep 27, 2018
Contributor
pongad
left a comment
There was a problem hiding this comment.
LGTM. I'll leave it up to you if Luke or Andrea should also take a look.
Contributor
Author
|
@lukesneeringer what do you think? |
lukesneeringer
approved these changes
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a little bit tired of changing version number in two files and it's error prone. Let's store the version only in
Dockerfile, and makesetup.pyparse it from there. Adding a little bit more logic intosetup.pymight not be a good idea, but having just one version number across the code looks like a good idea to me.