This repository was archived by the owner on Mar 1, 2022. It is now read-only.
Merged
Conversation
yihanzhen
approved these changes
Aug 7, 2019
yihanzhen
added a commit
that referenced
this pull request
Aug 15, 2019
Features from gapic-generator: - SampleGen: Sanity checks to sample configs before parsing them into proto parser - SampleGen: add license in Node.js samples - fix: gl-node x-googl-api-client header should not have 'v' prefix - throw exception when optional is empty - Switch to machine executor for Bazel builds (to fix tests flakiness) - Reconstruct PackagingConfig from other sources (gapic_yaml and protos) - SampleGen: Generate samples from sample configs in Java and C# Features from artman: - change gapic_samples to samples in artman config (#715) - Update dependency pbr to v5.4.2 (#709) - Update dependency babel to >=2.3.4, <2.8.0 (#708) - Unpin dependencies (#713)
Merged
yihanzhen
added a commit
that referenced
this pull request
Aug 15, 2019
Features from gapic-generator: - SampleGen: Sanity checks to sample configs before parsing them into proto parser - SampleGen: add license in Node.js samples - fix: gl-node x-googl-api-client header should not have 'v' prefix - throw exception when optional is empty - Switch to machine executor for Bazel builds (to fix tests flakiness) - Reconstruct PackagingConfig from other sources (gapic_yaml and protos) - SampleGen: Generate samples from sample configs in Java and C# Features from artman: - change gapic_samples to samples in artman config (#715) - Update dependency pbr to v5.4.2 (#709) - Update dependency babel to >=2.3.4, <2.8.0 (#708) - Unpin dependencies (#713)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate pinned dependencies in #684 and this is not what we want since having a lot of dependencies pinned lead to a huge amount of spam in PRs. This PR safely unpins most of them, effectively reverting #684 but with extra checks that won't allow major version bumps.
Renovate config was changed accordingly in #704.