-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test: add integration tests for collections #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Release-As: 0.18.0
Clarify the differences between GitHub Action link checks and Hugo server link resolution.
This reverts commit 85ca6d7.
Summary of ChangesHello @rahulpinto19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the reliability of integration tests across various database systems by implementing robust pre-creation cleanup mechanisms and unique resource naming strategies. These changes ensure a clean testing environment for each run, preventing interference from previous test failures and avoiding naming conflicts. Additionally, the PR includes an update to the developer documentation regarding link checking practices. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the reliability of integration tests by introducing pre-creation cleanup and unique naming for test resources. These are excellent changes for test stability. My review includes suggestions to further improve the code by handling errors in cleanup steps, removing commented-out code, and addressing minor formatting and typos.
8a8c275 to
c5e9765
Compare
c5e9765 to
b7c2b1a
Compare
This PR improves the reliability of the collection creation process by introducing two key changes:
Pre-creation Cleanup: It now clears existing collections before a new one is initialized to ensure a clean state.
Collision Prevention: It implements unique table naming logic to avoid naming conflicts and resource collisions during the creation process.