samples: Schema evolution #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kamalaboulhosn Samples failing test and checkstyle. |
hongalex
reviewed
Jan 31, 2023
samples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java
Outdated
Show resolved
Hide resolved
* samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add back in working asserts * Formatting fixes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Version/delete fixes * samples: schema evolution * samples: schema evolution * Format fixes * Fix documentation for field. * Add back in working asserts * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Formatting fixes * Version/delete fixes --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…apis/java-pubsub into schema-evolution-examples
hongalex
reviewed
Feb 27, 2023
samples/snippets/src/main/java/pubsub/UpdateTopicSchemaExample.java
Outdated
Show resolved
Hide resolved
hongalex
reviewed
Feb 27, 2023
samples/snippets/src/main/java/pubsub/SubscribeWithAvroSchemaRevisionsExample.java
Outdated
Show resolved
Hide resolved
hongalex
reviewed
Feb 28, 2023
acocuzzo
approved these changes
Mar 11, 2023
acocuzzo
left a comment
There was a problem hiding this comment.
Left a couple comments re: exceptions, otherwise looks great! Thanks.
| System.out.println("Committed a schema using an Avro schema:\n" + schema); | ||
| return schema; | ||
| } catch (AlreadyExistsException e) { | ||
| System.out.println(schemaName + "already exists."); |
There was a problem hiding this comment.
We should probably change to FailedPrecondition/InvalidArgument/NotFound/ResourceExhausted, since we can't get AlreadyExists.
|
|
||
| System.out.println("Committed a schema using a protobuf schema:\n" + schema); | ||
| return schema; | ||
| } catch (AlreadyExistsException e) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.