-
Notifications
You must be signed in to change notification settings - Fork 233
feat: Annotate some resource fields with their corresponding API types #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gcf-owl-bot
wants to merge
2
commits into
main
Choose a base branch
from
owl-bot-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owl bot is regenerating pull request 2058... |
03724a6
to
cc5ffcf
Compare
Owl bot is regenerating pull request 2058... |
PiperOrigin-RevId: 813843285 Source-Link: googleapis/googleapis@c61d80b Source-Link: googleapis/googleapis-gen@e195618 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9 feat: support the protocol version in StreamingPullRequest PiperOrigin-RevId: 812818419 Source-Link: googleapis/googleapis@a4ded73 Source-Link: googleapis/googleapis-gen@d9dd704 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDlkZDcwNDc4MzQ5ZDdkYWY1MGMwYTU0NTMxNjA1MzA2NWI3ZTAxOSJ9 chore: update generator logic for nodejs_gapic_combined_pkg rule, and update templates PiperOrigin-RevId: 808677883 Source-Link: googleapis/googleapis@a32846d Source-Link: googleapis/googleapis-gen@593da26 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTkzZGEyNjUyZjJjNDNiNzY5ZGZlYjE5MTYxYTNiZTk1NWY5NzY3NCJ9 chore: improve README and fix combined gapic rule generation chore: request.id should be typecast to a string PiperOrigin-RevId: 803577907 Source-Link: googleapis/googleapis@8f0f886 Source-Link: googleapis/googleapis-gen@6c5556d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmM1NTU2ZDA1YjllM2U0YmJlMWE3OGIzNmRhYTAxZjlhMzk4ZGVjMSJ9 chore: remove unneeded BAZEL import PiperOrigin-RevId: 802775018 Source-Link: googleapis/googleapis@af3f926 Source-Link: googleapis/googleapis-gen@48e4634 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDhlNDYzNDQwZTk2M2MxNTUxM2VkMWM3NjY3NDk3NTU0NmY2ZGJhNiJ9 chore: remove .md extension on LICENSE files PiperOrigin-RevId: 802685533 Source-Link: googleapis/googleapis@0d129bf Source-Link: googleapis/googleapis-gen@73664e2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzM2NjRlMjAwMjUzZGRiOGRlMmI5YmI5YzY1ZjZiNjgzMDExMDJmYiJ9 chore: add top-level BUILD rule for new bundled generation process PiperOrigin-RevId: 802243639 Source-Link: googleapis/googleapis@4a2d23d Source-Link: googleapis/googleapis-gen@03d5b98 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDNkNWI5ODBmZDkxMmY4ZTI4MWY4MTc3NDRhOWNlZjM1YWFmMzMzMCJ9 fix: Remove element_count_limit and request_byte_limit from pubsub_gapic.yaml PiperOrigin-RevId: 780815892 Source-Link: googleapis/googleapis@898bcf4 Source-Link: googleapis/googleapis-gen@56d0612 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTZkMDYxMjZkY2MwYWZkZTI5YWZkOGVjMjI4NzVkZmJhNWI1YTgxNSJ9 feat: Add MessageTransformationFailureReason to IngestionFailureEvent docs: Document that the `acknowledge_confirmation` and `modify_ack_deadline_confirmation` fields in message `.google.pubsub.v1.StreamingPullResponse` are not guaranteed to be populated PiperOrigin-RevId: 776198381 Source-Link: googleapis/googleapis@ade5fe4 Source-Link: googleapis/googleapis-gen@2e304e4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmUzMDRlNDk5ZDBiNDk5NmEzNWJkYzY1ZDg3NmU0YjIxYjI2NTkzNyJ9 feat: add methods from gax to cache proto root and process custom error details fix: distinguish plural and singular path templates PiperOrigin-RevId: 772168312 Source-Link: googleapis/googleapis@873d84e Source-Link: googleapis/googleapis-gen@f448c1b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ0OGMxYjRlYWFhNWZkYzcwMjFhNjgyMDY4YzMxM2Q2ZjJmMTA0YSJ9
e28a125
to
8ba0df2
Compare
feat: Add AwsKinesisFailureReason.ApiViolationReason feat: Add tags to Subscription, Topic, and CreateSnapshotRequest messages for use in CreateSubscription, CreateTopic, and CreateSnapshot requests respectively docs: A comment for field `received_messages` in message `.google.pubsub.v1.StreamingPullResponse` is changed PiperOrigin-RevId: 820071518 Source-Link: googleapis/googleapis@e938992 Source-Link: googleapis/googleapis-gen@825a3ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODI1YTNjYWEyNGYwYmYxNzBmMWM1NmVhNWYyY2Y3MzRmOGY5ZmM1MSJ9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
owl-bot-copy
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add AwsKinesisFailureReason.ApiViolationReason
feat: Add tags to Subscription, Topic, and CreateSnapshotRequest messages for use in CreateSubscription, CreateTopic, and CreateSnapshot requests respectively
docs: A comment for field
received_messages
in message.google.pubsub.v1.StreamingPullResponse
is changedPiperOrigin-RevId: 820071518
Source-Link: googleapis/googleapis@e938992
Source-Link: https://github.com/googleapis/googleapis-gen/commit/825a3caa24f0bf170f1c56ea5f2cf734f8f9fc51
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODI1YTNjYWEyNGYwYmYxNzBmMWM1NmVhNWYyY2Y3MzRmOGY5ZmM1MSJ9
BEGIN_NESTED_COMMIT
chore: run compileProtos and update gapic-node-processing
PiperOrigin-RevId: 813843285
Source-Link: googleapis/googleapis@c61d80b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/e195618e85af7e4a092e4493a58c21fd43d7d148
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5NTYxOGU4NWFmN2U0YTA5MmU0NDkzYTU4YzIxZmQ0M2Q3ZDE0OCJ9
feat: support the protocol version in StreamingPullRequest
PiperOrigin-RevId: 812818419
Source-Link: googleapis/googleapis@a4ded73
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d9dd70478349d7daf50c0a545316053065b7e019
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDlkZDcwNDc4MzQ5ZDdkYWY1MGMwYTU0NTMxNjA1MzA2NWI3ZTAxOSJ9
chore: update generator logic for nodejs_gapic_combined_pkg rule, and update templates
PiperOrigin-RevId: 808677883
Source-Link: googleapis/googleapis@a32846d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/593da2652f2c43b769dfeb19161a3be955f97674
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTkzZGEyNjUyZjJjNDNiNzY5ZGZlYjE5MTYxYTNiZTk1NWY5NzY3NCJ9
chore: improve README and fix combined gapic rule generation
chore: request.id should be typecast to a string
PiperOrigin-RevId: 803577907
Source-Link: googleapis/googleapis@8f0f886
Source-Link: https://github.com/googleapis/googleapis-gen/commit/6c5556d05b9e3e4bbe1a78b36daa01f9a398dec1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmM1NTU2ZDA1YjllM2U0YmJlMWE3OGIzNmRhYTAxZjlhMzk4ZGVjMSJ9
chore: remove unneeded BAZEL import
PiperOrigin-RevId: 802775018
Source-Link: googleapis/googleapis@af3f926
Source-Link: https://github.com/googleapis/googleapis-gen/commit/48e463440e963c15513ed1c76674975546f6dba6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDhlNDYzNDQwZTk2M2MxNTUxM2VkMWM3NjY3NDk3NTU0NmY2ZGJhNiJ9
chore: remove .md extension on LICENSE files
PiperOrigin-RevId: 802685533
Source-Link: googleapis/googleapis@0d129bf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/73664e200253ddb8de2b9bb9c65f6b68301102fb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzM2NjRlMjAwMjUzZGRiOGRlMmI5YmI5YzY1ZjZiNjgzMDExMDJmYiJ9
chore: add top-level BUILD rule for new bundled generation process
PiperOrigin-RevId: 802243639
Source-Link: googleapis/googleapis@4a2d23d
Source-Link: https://github.com/googleapis/googleapis-gen/commit/03d5b980fd912f8e281f817744a9cef35aaf3330
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDNkNWI5ODBmZDkxMmY4ZTI4MWY4MTc3NDRhOWNlZjM1YWFmMzMzMCJ9
fix: Remove element_count_limit and request_byte_limit from pubsub_gapic.yaml
PiperOrigin-RevId: 780815892
Source-Link: googleapis/googleapis@898bcf4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/56d06126dcc0afde29afd8ec22875dfba5b5a815
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTZkMDYxMjZkY2MwYWZkZTI5YWZkOGVjMjI4NzVkZmJhNWI1YTgxNSJ9
feat: Add MessageTransformationFailureReason to IngestionFailureEvent
docs: Document that the
acknowledge_confirmation
andmodify_ack_deadline_confirmation
fields in message.google.pubsub.v1.StreamingPullResponse
are not guaranteed to be populatedPiperOrigin-RevId: 776198381
Source-Link: googleapis/googleapis@ade5fe4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2e304e499d0b4996a35bdc65d876e4b21b265937
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmUzMDRlNDk5ZDBiNDk5NmEzNWJkYzY1ZDg3NmU0YjIxYjI2NTkzNyJ9
feat: add methods from gax to cache proto root and process custom error details
fix: distinguish plural and singular path templates
PiperOrigin-RevId: 772168312
Source-Link: googleapis/googleapis@873d84e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f448c1b4eaaa5fdc7021a682068c313d6f2f104a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ0OGMxYjRlYWFhNWZkYzcwMjFhNjgyMDY4YzMxM2Q2ZjJmMTA0YSJ9
END_NESTED_COMMIT