FIX #182 #183
FIX #182 #183
Conversation
goose3/extractors/authors.py
Outdated
| if isinstance(author, dict): | ||
| authors.append(author.get("name", "")) | ||
| author = author.get("name", None) | ||
| if author: |
There was a problem hiding this comment.
please use a different variable than author, it is the same as the loop variable extracted_author may be more appropriate
There was a problem hiding this comment.
Good point - I have updated the PR. Any idea when you will create a new pip release?
goose3/extractors/authors.py
Outdated
| if isinstance(author, dict): | ||
| author = author.get("name", None) | ||
| extracted_author = author.get("name", None) | ||
| if author: |
There was a problem hiding this comment.
Shouldn't this also be extracted author? Otherwise a None might be inserted into the array. (Line 73)
There was a problem hiding this comment.
You are completely right - stupid oversight on my part. Thanks for catching it!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 91.43% 91.44%
=======================================
Files 30 30
Lines 2464 2465 +1
=======================================
+ Hits 2253 2254 +1
Misses 211 211
|
|
@lababidi if you are good with this PR, we can merge and we can then push a new version. |
|
@barrust looks good. I would simplify eventually to |
As requested, I''ve opened a PR to fix it.