Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Vasniktel
Copy link
Contributor

Fixes #211

Uses https://github.com/polm/fugashi library. The wheel is about 250 MB, hence the dependency is optional.

@Vasniktel
Copy link
Contributor Author

Tests in an unrelated code are failing.

@barrust
Copy link
Collaborator

barrust commented Sep 14, 2025

Thank you for the PR! If you revert the changes to the .github/workflows/python-package.yml I'd be happy to merge it in. I believe I figured out the issue with the tests and have the fix in another PR: #214

@Vasniktel Vasniktel force-pushed the add-japanese-tokenizer branch from 38f2899 to a511544 Compare September 14, 2025 07:17
@Vasniktel
Copy link
Contributor Author

Done

@barrust barrust merged commit 60ac8f7 into goose3:master Sep 14, 2025
2 of 8 checks passed
@Vasniktel Vasniktel deleted the add-japanese-tokenizer branch September 14, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Japanese support?

2 participants