archive/zip: honor Modified field in CreateRaw#76986
Open
heathdutton wants to merge 1 commit intogolang:masterfrom
Open
archive/zip: honor Modified field in CreateRaw#76986heathdutton wants to merge 1 commit intogolang:masterfrom
heathdutton wants to merge 1 commit intogolang:masterfrom
Conversation
Contributor
|
This PR (HEAD: 1041ef1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/732600. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/732600. |
CreateRaw was ignoring the Modified field in FileHeader, requiring users to call the deprecated SetModTime method as a workaround. This change adds the same timestamp handling logic to CreateRaw that CreateHeader already uses. Fixes golang#76741
1041ef1 to
f3e1838
Compare
Contributor
|
This PR (HEAD: f3e1838) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/732600. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateRaw was ignoring the Modified field in FileHeader, requiring users to call the deprecated
SetModTimemethod as a workaround.This change adds the same timestamp handling logic to
CreateRawthatCreateHeaderalready uses.Fixes #76741