regexp: standardize error message format in find_test.go#77005
regexp: standardize error message format in find_test.go#77005jjpinto wants to merge 1 commit intogolang:masterfrom
Conversation
Standardize error message format in find_test.go
|
This PR (HEAD: e9613ac) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/732780. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Jorge Pinto: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-12-29T19:07:46Z","revision":"f027ccc0bf7340f5d5758ed549a0f58058ca6140"} Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Keith Randall: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
This change updates the test error messages in find_test.go to follow the Go standard 'got, want' format. It also replaces 'expected/should be' terminology with the project's preferred style and improves the clarity of failure logs by using %q to quote string values. Change-Id: I17bfc60a06a879ce5e2c64d624c636e2c24135e9 GitHub-Last-Rev: e9613ac GitHub-Pull-Request: #77005 Reviewed-on: https://go-review.googlesource.com/c/go/+/732780 Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Keith Randall <[email protected]>
|
Message from Cherry Mui: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732780. |
|
This PR is being closed because golang.org/cl/732780 has been merged. |
This change updates the test error messages in find_test.go to follow
the Go standard 'got, want' format.
It also replaces 'expected/should be' terminology with the project's
preferred style and improves the clarity of failure logs by using %q
to quote string values.