Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 9, 2021. It is now read-only.

Conversation

gliptak
Copy link

@gliptak gliptak commented Oct 21, 2018

No description provided.

@gopherbot
Copy link

This PR (HEAD: dcbcb67) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/lint/+/143546 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/143546.
After addressing review feedback, remember to publish your drafts!

@gliptak
Copy link
Author

gliptak commented Oct 21, 2018

HEAD is broken for Go 1.7 and 1.8 https://travis-ci.org/golang/lint/builds/444499244

Co-Authored-By: gliptak <[email protected]>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@gopherbot
Copy link

This PR (HEAD: c297132) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/lint/+/143546 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Co-Authored-By: gliptak <[email protected]>
gopherbot pushed a commit that referenced this pull request Oct 23, 2018
Change-Id: Ic99795cb521e8e9c1124b05628fec41c176ded25
GitHub-Last-Rev: c297132
GitHub-Pull-Request: #420
Reviewed-on: https://go-review.googlesource.com/c/143546
Reviewed-by: Brad Fitzpatrick <[email protected]>
@andybons
Copy link
Member

This has already been done. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants