Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improved documentation on Nvidia GPU card detection, and error messag… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janpfeifer merged 3 commits into from
Dec 3, 2024
Merged

Improved documentation on Nvidia GPU card detection, and error messag… #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4c7ca9
Improved documentation on Nvidia GPU card detection, and error messag…
janpfeifer Dec 3, 2024
650c3f2
Updated GitHub action (`go.yaml`) to only change the README.md with t…
janpfeifer Dec 3, 2024
7d43d3f
Only update badge is pushing to main.
janpfeifer Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/go.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Tests only run with --short, since the full tests involve downloading datasets
# and would be too costly for a Github actions.
# and would be too costly for a GitHub actions.
# Locally in the development box it works because the datasets are cached.
name: "Tests" # The name of the workflow that will appear on Github
name: "Tests" # The name of the workflow that will appear on GitHub
permissions:
# read|write|none
actions: read
Expand Down Expand Up @@ -59,12 +59,14 @@ jobs:
go test ./xlabuilder/... ./pjrt/...

- name: Go Coverage Badge
if: github.ref == 'refs/heads/main'
uses: tj-actions/coverage-badge-go@v2
with:
green: 80
filename: docs/coverage.out

- name: Commit README.md changes
if: github.ref == 'refs/heads/main'
run: |
if git diff --quiet -- 'README.md' ; then
echo "README.md not modified."
Expand All @@ -76,6 +78,7 @@ jobs:
fi

- name: Push Changes
if: github.ref == 'refs/heads/main'
uses: ad-m/github-push-action@master
with:
github_token: ${{ github.token }}
Expand Down
3 changes: 3 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
* Added `install_linux_amd64_amazonlinux.sh` and pre-built libraries for amazonlinux (built using old glibc support).
* Fixed installation scripts: s/sudo/$_SUDO. Also made them more verbose.
* Removed dependency on `xargs` in installation script for Linux.
* Improved documentation on Nvidia GPU card detection, and error message if not found.
* Updated GitHub action (`go.yaml`) to only change the README.md with the result of the change, if pushing to the
`main` branch.

# v0.4.9 - 2024-11-25

Expand Down
8 changes: 7 additions & 1 deletion pjrt/cuda.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ func isCuda(name string) bool {

var hasNvidiaGPUCache *bool

// hasNvidiaGPU tries to guess if there is an Nvidia GPU installed.
// hasNvidiaGPU tries to guess if there is an actual Nvidia GPU installed (as opposed to only the drivers/PJRT
// file installed, but no actual hardware).
// It does that by checking for the presence of the device files in /dev/nvidia*.
func hasNvidiaGPU() bool {
if hasNvidiaGPUCache != nil {
return *hasNvidiaGPUCache
Expand All @@ -29,6 +31,10 @@ func hasNvidiaGPU() bool {
return false
}
hasGPU := len(matches) > 0
if !hasGPU {
klog.Infof("No NVidia devices found matching \"/dev/nvidia*\", assuming there are no GPU cards installed in the system. " +
"To force the attempt to use the \"cuda\" PJRT, use its absolute path.")
}
hasNvidiaGPUCache = &hasGPU
return hasGPU
}
Expand Down
Loading