Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed Scatter parameter indicesAreSorted and isUnique. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janpfeifer merged 1 commit into from
Apr 13, 2025
Merged

Fixed Scatter parameter indicesAreSorted and isUnique. #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c/gomlx/xlabuilder/xlabuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ XlaStatus *XlaBuilderAddOp(XlaBuilder *builder, SerializedOp *serialized_op) {
int pos = 0;
xla::ScatterDimensionNumbers scatter_dims;
scatter_dims.set_index_vector_dim(serialized_op->integer_array[pos++]);
bool unique_indices = bool(serialized_op->integer_array[pos++]);
bool indices_are_sorted = bool(serialized_op->integer_array[pos++]);
bool unique_indices = bool(serialized_op->integer_array[pos++]);
int64_t len_update_window_dims = serialized_op->integer_array[pos++];
int64_t len_inserted_window_dims = serialized_op->integer_array[pos++];
int64_t len_scatter_dims_to_operand_dims = serialized_op->integer_array[pos++];
Expand Down
6 changes: 5 additions & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Gopjrt Changelog

# v0.6.3 - 2025/04/10
# Next

* Fixed Scatter functions: indicesAreSorted and uniqueIndices were reversed.

# v0.6.3 - 2025/04/11

* Fixed small memory leak of a VectorData wrapper when converting to HLO/StableHLO (#31).
* Fixed leak when destroying XlaBuilder.
Expand Down