Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed leak when destroying XlaBuilder. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janpfeifer merged 1 commit into from
Mar 12, 2025
Merged

Fixed leak when destroying XlaBuilder. #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Next

* Fixed small memory leak of a VectorData wrapper when converting to HLO/StableHLO (#31).
* Fixed leak when destroying XlaBuilder.

# v0.6.2 - 2025/02/26

Expand Down
3 changes: 2 additions & 1 deletion xlabuilder/xlabuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,14 @@ func (b *XlaBuilder) Destroy() {
if b.IsNil() {
return
}
cXlaBuilder := b.cXlaBuilder
b.cXlaBuilder = nil
b.parent = nil // Help the GC just in case.
for _, subComp := range b.cachedStandardComputations {
subComp.Destroy()
}
b.cachedStandardComputations = nil
C.XlaBuilderDestroy(unsafe.Pointer(b.cXlaBuilder))
C.XlaBuilderDestroy(unsafe.Pointer(cXlaBuilder))
}

// Name returns the name after it was canonicalized by the XlaBuilder library -- so it may be different from the
Expand Down
Loading