Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added IsInfinite and PopulationCount operations. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janpfeifer merged 1 commit into from
Oct 3, 2024
Merged

Added IsInfinite and PopulationCount operations. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions c/gomlx/xlabuilder/gen_op_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ enum OpType {
DynamicSliceOp,
DynamicUpdateSliceOp,
ErfOp,
IsFiniteOp,
PopulationCountOp,
};

#ifdef __cplusplus
Expand Down
6 changes: 6 additions & 0 deletions c/gomlx/xlabuilder/xlabuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,12 @@ XlaStatus *XlaBuilderAddOp(XlaBuilder *builder, SerializedOp *serialized_op) {
case ErfOp:
op = xla::Erf(*inputs[0]);
break;
case IsFiniteOp:
op = xla::IsFinite(*inputs[0]);
break;
case PopulationCountOp:
op = xla::PopulationCount(*inputs[0]);
break;

// Two-arguments ops
case AddOp:
Expand Down
2 changes: 1 addition & 1 deletion cmd/protoc_xla_protos/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const (
)

var protos = []string{
"third_party/tsl/tsl/protobuf/dnn.proto",
"xla/tsl/protobuf/dnn.proto",
"xla/autotune_results.proto",
"xla/autotuning.proto",
"xla/pjrt/compile_options.proto",
Expand Down
9 changes: 8 additions & 1 deletion cmd/xlabuilder_codegen/go_ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,16 @@ func TestSimpleOps(t *testing.T) {
result, err = And(result, same)
require.NoError(t, err, "Failed to build And operation")

result, err = IsFinite(x)
require.NoError(t, err, "Failed to build IsFinite operation")
require.Equal(t, dtypes.Bool, result.Shape.DType, "IsFinite should return booleans")

require.NoError(t, err, "Failed to build And operation")
i, err = Clz(i)
require.NoError(t, err, "Failed to build Clz operation")

i, err = PopulationCount(i)
require.NoError(t, err, "Failed to build PopulationCount operation")
same, err = Equal(i, i)
require.NoError(t, err, "Failed to build Equal operation")

Expand Down Expand Up @@ -149,7 +156,7 @@ func GenerateSimpleGoOps(opsInfo []OpInfo) {
fmt.Printf("Generated %q based on %q\n", fileName, OpTypesFileName)

// For testing we skip some that require special types.
skip := []string{"LogicalNot", "And", "Or", "Xor", "Dot", "Clz", "Real", "Imag", "Conj", "Complex"}
skip := []string{"LogicalNot", "And", "Or", "Xor", "Dot", "Clz", "Real", "Imag", "Conj", "Complex", "IsFinite", "PopulationCount"}
filteredOps := slices.DeleteFunc(opsInfo, func(info OpInfo) bool {
return slices.Index(skip, info.Name) != -1
})
Expand Down
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v0.4.2 - 2024-10-03

* Added `IsFinite` and `PopulationCount` operations.

# v0.4.1 - 2024-09-28

* Added memory layout information in buffer-to-host transfers: required for TPU.
Expand Down
397 changes: 241 additions & 156 deletions protos/autotuning/autotuning.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading