Fix off by one indexing bug in plotutil.MedianAndMinMax #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the mean of the two inner-most elements in the slice.
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
==========================================
- Coverage 73.32% 73.23% -0.09%
==========================================
Files 56 58 +2
Lines 5154 5366 +212
==========================================
+ Hits 3779 3930 +151
- Misses 1191 1243 +52
- Partials 184 193 +9
Continue to review full report at Codecov.
|
|
Thank you. Would you please open a PR at gonum/gonum with the commit message "A+C: add Scott Kiesel" adding your details to the AUTHORS and CONTRIBUTORS files. When you have done that I'll approve and merge. |
kortschak
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix off by one indexing bug in plotutil.MedianAndMinMax when determining the mean of the two inner-most elements in the slice.
Please take a look.