Fix release-build.sh for macOS #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great catch, didn't notice that MacOS was missing from the RC. Thank you for the contribution! |
aelsabbahy
approved these changes
Aug 5, 2023
Contributor
Author
|
Thank you for your quick confirmation! |
Member
|
Hmm, seems like there are still no osx binaries in the latest release. @petemounce I think you were involved in some of those scripts. Any idea why osx might be failing? |
Contributor
Author
|
@aelsabbahy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This pull request fixes release-build.sh to run "make build" on macOS.
On macOS, "make build" failed because there is no sha256sum command in the default environment.